lkml.org 
[lkml]   [2005]   [Mar]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [patch] oom_kill fix
On Mon, 14 Mar 2005 18:02:58 -0800, Andrew Morton <akpm@osdl.org> wrote:
> Coywolf Qi Hunt <coywolf@sosdg.org> wrote:
> >
> > This oom_kill fix is to do mmput(mm) a bit earlier and returning 0 or 1
> > to indicate success or failure instead of returning mm_struct pointer.
>
> Why is this a "fix"? What bug is it fixing?
>

It's at least a coding style improvement and lets the code be less obfuscated.
It increases the system survival possibilities by doing mmput immediately
and reduces the chances of oom killing another process unnecessarily, IMHO.

Or rather rename "fix" to "cleanup".

--
Coywolf Qi Hunt
http://sosdg.org/~coywolf/
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-03-22 14:11    [W:0.384 / U:0.544 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site