lkml.org 
[lkml]   [2005]   [Feb]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [rfc][patch] ide: fix unneeded LBA48 taskfile registers access

Okay, another quick question.

To fix the io_32bit race problem in ide_taskfile_ioctl() (and later
ide_cmd_ioctl() too), it seems simplest to mark the taskfile with
something like ATA_TFLAG_IO_16BIT flag and use the flag in task_in_intr().

However, ATA_TFLAG_* are used by libata, and I think that, although
sharing hardware constants is good if the hardware is similar, sharing
driver-specific flags isn't such a good idea. So, what do you think?

1. Add ATA_TFLAG_IO_16BIT to ata.h
2. Make ide's own set of task flags, maybe IDE_TFLAG_* (including
IDE_TFLAG_LBA48)

--
tejun

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-03-22 14:10    [W:0.044 / U:0.696 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site