lkml.org 
[lkml]   [2005]   [Feb]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [2.6 patch] add compiler-gcc4.h
On Thu, Feb 03, 2005 at 01:04:46AM +0000, H. Peter Anvin wrote:
> Followup to: <41FCFED4.1070301@tiscali.de>
> By author: Matthias-Christian Ott <matthias.christian@tiscali.de>
> In newsgroup: linux.dev.kernel
> >
> > Hi!
> > But maybe gcc 4 will get different later, so I think this patch makes sense.
> >
>
> No, it doesn't. You fork when you have a reason. Eager forking is
> *BAD*.

As I already said in this thread:
The currently used file for gcc 4 is compiler-gcc+.h, not
compiler-gcc3.h .

And the current setup is to have one file for every major number of gcc.
I have no strong opinion whether this approach or the approach of one
file for all gcc versions is better - but with the current approach,
everything else than a separate file for gcc 4 wasn't logical.

I can offer the following choices:
- please apply this compiler-gcc4.h patch
- let me send a patch merging all compiler-gcc*.h files into one
compiler-gcc.h file
- let me send a patch merging all compiler-gcc*.h files back into
compiler.h

> -hpa

cu
Adrian

--

"Is there not promise of rain?" Ling Tan asked suddenly out
of the darkness. There had been need of rain for many days.
"Only a promise," Lao Er said.
Pearl S. Buck - Dragon Seed

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-03-22 14:10    [W:0.073 / U:0.404 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site