| Date | Thu, 3 Feb 2005 01:00:15 +0100 | From | Bartlomiej Zolnierkiewicz <> | Subject | Re: [PATCH 2.6.11-rc2 02/29] ide: cleanup it8172 |
| |
On Wed, 2 Feb 2005 11:44:54 +0900, Tejun Heo <tj@home-tj.org> wrote: > > 02_ide_cleanup_it8172.patch > > > > In drivers/ide/pci/it8172.h, it8172_ratefilter() and > > init_setup_it8172() are declared and the latter is referenced > > in it8172_chipsets. Both functions are not defined or used > > anywhere. This patch removes the prototypes and reference. > > it8172 should be compilable now. > > Signed-off-by: Tejun Heo <tj@home-tj.org>
applied, also this trivial patch is needed to fix it8172 build:
diff -Nru a/drivers/ide/pci/it8172.c b/drivers/ide/pci/it8172.c --- a/drivers/ide/pci/it8172.c 2005-02-03 01:00:22 +01:00 +++ b/drivers/ide/pci/it8172.c 2005-02-03 01:00:22 +01:00 @@ -56,7 +56,7 @@ { ide_hwif_t *hwif = HWIF(drive); struct pci_dev *dev = hwif->pci_dev; - int is_slave = (hwif->drives[1] == drive); + int is_slave = (&hwif->drives[1] == drive); unsigned long flags; u16 drive_enables; u32 drive_timing; @@ -94,7 +94,7 @@ } pci_write_config_word(dev, 0x40, drive_enables); - spin_unlock_irqrestore(&ide_lock, flags) + spin_unlock_irqrestore(&ide_lock, flags); } static u8 it8172_dma_2_pio (u8 xfer_rate) - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
|