lkml.org 
[lkml]   [2005]   [Feb]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 2/2] page table iterators
    On Thu, Feb 17, 2005 at 03:30:31PM -0800, David S. Miller wrote:
    > On Fri, 18 Feb 2005 00:03:42 +0100
    > Andi Kleen <ak@suse.de> wrote:
    >
    > > And to be honest we only have about 6 or 7 of these walkers
    > > in the whole kernel. And 90% of them are in memory.c
    > > While doing 4level I think I changed all of them around several
    > > times and it wasn't that big an issue. So it's not that we
    > > have a big pressing problem here...
    >
    > It's super error prone. A regression added by your edit of these

    Actually it was in Nick's code (PUD layer ;-). But I won't argue
    that my code didn't have bugs too...

    > walkers for the 4level changes was only discovered and fixed
    > yesterday by the ppc folks.
    >
    > I absolutely support any change which consolidates these things.

    The problem is just that these walker macros when they
    do all the lazy walking stuff will be quite complicated.
    And I don't really want another uaccess.h-like macro mess.

    Yes currently they look simple, but that will change.

    Open coding is probably the smaller evil.

    And they're really not changed that often.

    -Andi
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2005-03-22 14:10    [W:0.020 / U:30.672 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site