Messages in this thread | | | From | Bodo Eggert <> | Subject | Re: [PATCH 0/4] linux-2.6-block: deactivating pagecache for benchmarks | Date | Sat, 03 Dec 2005 03:05:34 +0100 |
| |
Andrew Morton <akpm@osdl.org> wrote:
> + .procname = "drop-pagecache", > + .data = NULL, > + .maxlen = sizeof(int), > + .mode = 0644,
1) Shouldn't this be a trigger? Reading from a trigger doesn't make sense, especially when triggering on a read. .mode = 0200?
2) If you pass an int, wouldn't a bitmask selecting what to free make sense? (off cause -1 == everything) Maybe this would be overengineered.
-- Ich danke GMX dafür, die Verwendung meiner Adressen mittels per SPF verbreiteten Lügen zu sabotieren. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |