lkml.org 
[lkml]   [2005]   [Dec]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [Patch 11/31] V4L (0999) Some funcions now static and I2C hw code for IR
    Hi Mauro,

    [As a side note, it looks like there have been some distribution
    problems with this patchset... I can only see 0/31 (twice) on LKML and
    11/31 didn't make it to the lm-sensors list as it was supposed to. I
    received it twice though.]

    > From: Mauro Carvalho Chehab <mchehab@brturbo.com.br>
    >
    > - Some funcions are now declared as static
    > - Added a I2C code for InfraRed.

    Unrelated changes, this should have been two separate patches. Also,
    "I2C driver ID" would better describe what the second change is about
    than "I2C code".

    > --- git.orig/drivers/media/video/ir-kbd-i2c.c
    > +++ git/drivers/media/video/ir-kbd-i2c.c
    > @@ -278,7 +278,7 @@ static int ir_probe(struct i2c_adapter *
    >
    > static struct i2c_driver driver = {
    > .name = "ir remote kbd driver",
    > - .id = I2C_DRIVERID_EXP3, /* FIXME */
    > + .id = I2C_DRIVERID_I2C_IR,
    > .flags = I2C_DF_NOTIFY,
    > .attach_adapter = ir_probe,
    > .detach_client = ir_detach,

    That's a poor ID name you chose. The second "I2C" is totally redundant,
    and "IR" is a bit short and could mean about anything. Please change it to
    I2C_DRIVERID_IRKBD or I2C_DRIVERID_INFRARED or something.

    Thanks,
    --
    Jean Delvare
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2005-12-01 20:12    [W:0.029 / U:60.104 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site