Messages in this thread Patch in this message | | | Date | Fri, 18 Nov 2005 14:05:50 -0200 | From | Marcelo Tosatti <> | Subject | [PATCH] mpcore_wdt.c bogus fpos check |
| |
Hi,
drivers/char/watchdog/mpcore_wdt.c write function contains a check for (ppos != &file->f_pos). Such check used to make sense when a pointer to file->f_pos was handed by vfs_write(), not a copy of it as it stands now.
Has been broken since then... Don't have a device to test - does it work at all?
mpc8xx_wdt.c is similarly broken (patch will be sent separately).
Signed-off-by: Marcelo Tosatti <marcelo.tosatti@cyclades.com>
diff --git a/drivers/char/watchdog/mpcore_wdt.c b/drivers/char/watchdog/mpcore_wdt.c index da631c1..c9f545e 100644 --- a/drivers/char/watchdog/mpcore_wdt.c +++ b/drivers/char/watchdog/mpcore_wdt.c @@ -180,10 +180,6 @@ static ssize_t mpcore_wdt_write(struct f { struct mpcore_wdt *wdt = file->private_data; - /* Can't seek (pwrite) on this device */ - if (ppos != &file->f_pos) - return -ESPIPE; - /* * Refresh the timer. */ - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |