Messages in this thread Patch in this message | | | From | bob.picco@hp ... | Subject | [PATCH] cpuset - fix return without releasing semaphore | Date | Fri, 11 Nov 2005 19:20:45 -0700 (MST) |
| |
It seems wrong to acquire the semaphore and then return from cpuset_zone_allowed without releasing it. This was only compile tested.
bob
Signed-off-by: Bob Picco <bob.picco@hp.com>
kernel/cpuset.c | 5 +++--
1 files changed, 3 insertions(+), 2 deletions(-)
Index: linux-2.6.14-mm1/kernel/cpuset.c =================================================================== --- linux-2.6.14-mm1.orig/kernel/cpuset.c 2005-11-07 07:00:13.000000000 -0500 +++ linux-2.6.14-mm1/kernel/cpuset.c 2005-11-09 17:56:28.000000000 -0500 @@ -2036,11 +2036,12 @@ int cpuset_zone_allowed(struct zone *z, if (gfp_mask & __GFP_HARDWALL) /* If hardwall request, stop here */ return 0; + if (current->flags & PF_EXITING) /* Let dying task have memory */ + return 1; + /* Not hardwall and node outside mems_allowed: scan up cpusets */ down(&callback_sem); - if (current->flags & PF_EXITING) /* Let dying task have memory */ - return 1; task_lock(current); cs = nearest_exclusive_ancestor(current->cpuset); task_unlock(current); - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |