Messages in this thread | | | Date | Fri, 28 Oct 2005 07:23:49 +0200 | From | Marcel Selhorst <> | Subject | Re: [PATCH] Infineon TPM: move infineon driver off pci_dev |
| |
Hi Andrew,
> This final return will leak the I/O region from request_region(). > If for some reason the leak is deliberate then a comment is needed.
yep, you're right, I'll fix that
> To reduce the chance of this happening again, please send a followup patch > which prevents this function from having `return' statements sprinkled all > over it. An example would be drivers/net/8139cp.c:cp_init_one(), thanks.
I will send a follow-up patch including the comments of Matthieu.
Thanks for reviewing!
Marcel - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |