lkml.org 
[lkml]   [2005]   [Oct]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH] Infineon TPM: move infineon driver off pci_dev
    Hi Andrew,

    > This final return will leak the I/O region from request_region().
    > If for some reason the leak is deliberate then a comment is needed.

    yep, you're right, I'll fix that

    > To reduce the chance of this happening again, please send a followup patch
    > which prevents this function from having `return' statements sprinkled all
    > over it. An example would be drivers/net/8139cp.c:cp_init_one(), thanks.

    I will send a follow-up patch including the comments of Matthieu.

    Thanks for reviewing!

    Marcel
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2005-10-28 07:27    [W:0.019 / U:34.136 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site