lkml.org 
[lkml]   [2005]   [Oct]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] Infineon TPM: move infineon driver off pci_dev
From
Date
Andrew, a few comments on your trivial comments:

> -static int tpm_atml_send(struct tpm_chip *chip, u8 * buf, size_t count)
> +static int tpm_atml_send(struct tpm_chip *chip, u8 *buf, size_t count)
There's still an extra space there I think.

> - data = kmalloc(READ_PUBEK_RESULT_SIZE, GFP_KERNEL);
> + data = kxalloc(READ_PUBEK_RESULT_SIZE, GFP_KERNEL);
When did we add kxalloc()? And what does it do?

> -ssize_t tpm_write(struct file * file, const char __user * buf,
> +ssize_t tpm_write(struct file * file, const char __user *buf,
Why delete one space between * and buf but not the one between * and file?

- R.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-10-28 00:07    [from the cache]
©2003-2011 Jasper Spaans