Messages in this thread | | | Date | Wed, 26 Oct 2005 19:41:24 +0200 | From | matthieu castet <> | Subject | Re: [PATCH] Infineon TPM: move infineon driver off pci_dev |
| |
Hi,
Marcel Selhorst wrote: > Dear all, > > the following patch moves the Infineon TPM driver off pci device > and makes it a pure pnp-driver. It was tested with IFX0101 and > IFX0102 and is now based on the tpm patchset (1 to 5) from Kylene > Hall submitted yesterday. > > Best regards, > > Marcel Selhorst > > Signed-off-by: Marcel Selhorst <selhorst@crypto.rub.de> > --- > > diff -pruN linux-2.6.14-rc5.ibm/drivers/char/tpm/tpm_infineon.c > linux-2.6.14-rc5.infineon_v1.6/drivers/char/tpm/tpm_infineon.c > --- linux-2.6.14-rc5.ibm/drivers/char/tpm/tpm_infineon.c 2005-10-26 > 15:21:53.000000000 +0200 > +++ linux-2.6.14-rc5.infineon_v1.6/drivers/char/tpm/tpm_infineon.c 2005-10-26 > 15:21:42.000000000 +0200 > @@ -5,6 +5,7 @@ > * Specifications at www.trustedcomputinggroup.org > * > * Copyright (C) 2005, Marcel Selhorst <selhorst@crypto.rub.de> > + * Sirrix AG - security technologies, http://www.sirrix.com and > * Applied Data Security Group, Ruhr-University Bochum, Germany > * Project-Homepage: http://www.prosec.rub.de/tpm > * > @@ -31,7 +32,7 @@ > /* These values will be filled after PnP-call */
> + /* read IO-ports through PnP */ > + if (pnp_port_valid(dev, 0) && > + !(pnp_port_flags(dev, 0) & IORESOURCE_DISABLED)) { > + TPM_INF_ADDR = pnp_port_start(dev, 0); > + TPM_INF_DATA = (TPM_INF_ADDR + 1); > + TPM_INF_BASE = pnp_port_start(dev, 1); You should add a pnp_port_valid(dev, 1) check. If you are paranoid, you could also check the port len.
I don't remember if it is done somewhere, but a request_region should be used.
The others parts are ok for me.
Matthieu - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |