lkml.org 
[lkml]   [2005]   [Oct]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    Subject[PATCH] SELinux - remove unecessary size_t checks in selinuxfs
    This patch removes a bunch of unecessary checks for (size_t < 0) in 
    selinuxfs.

    Please apply.

    Author: Davi Arnaut <davi.arnaut@gmail.com>
    Signed-off-by: James Morris <jmorris@namei.org>
    Acked-by: Stephen Smalley <sds@tycho.nsa.gov>


    ---

    security/selinux/selinuxfs.c | 18 +++++++++---------
    1 files changed, 9 insertions(+), 9 deletions(-)

    diff --git a/security/selinux/selinuxfs.c b/security/selinux/selinuxfs.c
    --- a/security/selinux/selinuxfs.c
    +++ b/security/selinux/selinuxfs.c
    @@ -105,7 +105,7 @@ static ssize_t sel_write_enforce(struct
    ssize_t length;
    int new_value;

    - if (count < 0 || count >= PAGE_SIZE)
    + if (count >= PAGE_SIZE)
    return -ENOMEM;
    if (*ppos != 0) {
    /* No partial writes. */
    @@ -155,7 +155,7 @@ static ssize_t sel_write_disable(struct
    int new_value;
    extern int selinux_disable(void);

    - if (count < 0 || count >= PAGE_SIZE)
    + if (count >= PAGE_SIZE)
    return -ENOMEM;
    if (*ppos != 0) {
    /* No partial writes. */
    @@ -242,7 +242,7 @@ static ssize_t sel_write_load(struct fil
    goto out;
    }

    - if ((count < 0) || (count > 64 * 1024 * 1024)
    + if ((count > 64 * 1024 * 1024)
    || (data = vmalloc(count)) == NULL) {
    length = -ENOMEM;
    goto out;
    @@ -284,7 +284,7 @@ static ssize_t sel_write_context(struct
    if (length)
    return length;

    - if (count < 0 || count >= PAGE_SIZE)
    + if (count >= PAGE_SIZE)
    return -ENOMEM;
    if (*ppos != 0) {
    /* No partial writes. */
    @@ -332,7 +332,7 @@ static ssize_t sel_write_checkreqprot(st
    if (length)
    return length;

    - if (count < 0 || count >= PAGE_SIZE)
    + if (count >= PAGE_SIZE)
    return -ENOMEM;
    if (*ppos != 0) {
    /* No partial writes. */
    @@ -739,7 +739,7 @@ static ssize_t sel_read_bool(struct file
    if (!filep->f_op)
    goto out;

    - if (count < 0 || count > PAGE_SIZE) {
    + if (count > PAGE_SIZE) {
    ret = -EINVAL;
    goto out;
    }
    @@ -800,7 +800,7 @@ static ssize_t sel_write_bool(struct fil
    if (!filep->f_op)
    goto out;

    - if (count < 0 || count >= PAGE_SIZE) {
    + if (count >= PAGE_SIZE) {
    length = -ENOMEM;
    goto out;
    }
    @@ -858,7 +858,7 @@ static ssize_t sel_commit_bools_write(st
    if (!filep->f_op)
    goto out;

    - if (count < 0 || count >= PAGE_SIZE) {
    + if (count >= PAGE_SIZE) {
    length = -ENOMEM;
    goto out;
    }
    @@ -1032,7 +1032,7 @@ static ssize_t sel_write_avc_cache_thres
    ssize_t ret;
    int new_value;

    - if (count < 0 || count >= PAGE_SIZE) {
    + if (count >= PAGE_SIZE) {
    ret = -ENOMEM;
    goto out;
    }
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/
    \
     
     \ /
      Last update: 2005-10-20 18:55    [W:0.024 / U:0.100 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site