Messages in this thread | | | Date | Sat, 8 Jan 2005 19:31:01 +0000 | From | Al Viro <> | Subject | Re: Export get_sb_pseudo()? |
| |
On Sat, Jan 08, 2005 at 10:40:10AM -0800, Roland Dreier wrote: > I'm planning on implementing some modular driver code and I think it > makes sense to have a non-mountable pseudofs. Especially with the > recent MVFS controversy, it seems prudent to find out whether this > usage would merit exporting get_sb_pseudo(), so I'll describe my > current plans below.
No objections; it certainly falls under "general-purpose library helper". Moreover, in this case I _insist_ on use of normal export; it is a convenience helper that a) can be trivially reimplemented by anyone who cares; any number of filesystems is open-coding far more than that in their ->get_sb(), so there's nothing to protect here. b) can be trivially simulated by simple_fill_super() followed by a bit of tweaking the result. c) does not shove any pitchforks into the kernel guts - resulting superblock does not require any special treatment.
So feel free to go ahead and export it; as the matter of fact, if you don't do it, I will. And that puppy is my code except for one line from Andi Kleen (sb->s_time_gran = 1; ;-). Since we both are OK with full export (I'd just asked him), anybody who has objections to that can take 'em and shove 'em... - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |