lkml.org 
[lkml]   [2005]   [Jan]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: Make pipe data structure be a circular list of pages, rather than
    Hello.

    pipe_writev:
    > + if (bufs < PIPE_BUFFERS) {
    > + ssize_t chars;
    > + int newbuf = (info->curbuf + bufs) & (PIPE_BUFFERS-1);

    If i understand this patch correctly, then this code

    for (;;)
    write(pipe_fd, &byte, 1);

    will block after writing PIPE_BUFFERS == 16 characters, no?
    And pipe_inode_info will use 64K to hold 16 bytes!

    Is it ok?

    May be it make sense to add data to the last allocated page
    until buf->len > PAGE_SIZE ?

    Oleg.
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2005-03-22 14:09    [W:0.031 / U:65.044 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site