Messages in this thread | | | Date | Thu, 6 Jan 2005 16:17:15 -0800 | From | Nishanth Aravamudan <> | Subject | FW: [KJ] ftape/fdc-io: schedule_timeout() usage |
| |
I haven't had any replies so far, and it was suggested that I also fish on LKML for input.
Thanks, Nish
----- Forwarded message from Nishanth Aravamudan <nacc@us.ibm.com> -----
Date: Wed, 5 Jan 2005 16:14:00 -0800 From: Nishanth Aravamudan <nacc@us.ibm.com> To: linux-tape@vger.kernel.org Cc: kernel-janitors@lists.osdl.org Subject: [KJ] ftape/fdc-io: schedule_timeout() usage
Hello,
I'm hoping someone here can help me correct some ftape code. drivers/char/ftape/lowlevel/fdc-io.c::fdc_interrupt_wait() contains the following code:
set_current_state(TASK_INTERRUPTIBLE); add_wait_queue((&ftape_wait_intr, &wait); while (!ft_interrupt_seen && (current->state == TASK_INTERRUPTIBLE)) { timeout = schedule_timeout(timeout); }
The problem I have is that after the first iteration of the loop (schedule_timeout() with TASK_INTERRUPTIBLE), it will become a busy-wait, as schedule_timeout() will be running with current->state set to TASK_RUNNING. I'm not sure if this is desired, but it seems weird to me. Any input would be appreciated.
-Nish
_______________________________________________ Kernel-janitors mailing list Kernel-janitors@lists.osdl.org http://lists.osdl.org/mailman/listinfo/kernel-janitors
----- End forwarded message ----- - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |