lkml.org 
[lkml]   [2004]   [Sep]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
Date
From
Subject2.6.9-rc2-mm2: devmem_is_allowed

Hi,

after switching from working 2.6.9-rc2 to -mm2, X refused to start on my
testbox. It turned out this was because it failed (EPERM) reading from
/dev/mem beyond the 1MB limit.

IMHO there is a typo in the test in devmem_is_allowed. The patch below
fixed the issue for me. Despite I think it's pretty clear the logic there
needs to be reverted, I'm somewhat uncertain because AFAICS nobody else
complained so far - did I miss something?

Martin

-------------

diff -urp linux-2.6.9-rc2-mm2/arch/i386/mm/init.c v2.6.9-rc2-mm2-md/arch/i386/mm/init.c
--- linux-2.6.9-rc2-mm2/arch/i386/mm/init.c Thu Sep 23 11:41:20 2004
+++ v2.6.9-rc2-mm2-md/arch/i386/mm/init.c Fri Sep 24 00:13:26 2004
@@ -239,7 +239,7 @@ int devmem_is_allowed(unsigned long page
{
if (pagenr <= 256)
return 1;
- if (!page_is_ram(pagenr))
+ if (page_is_ram(pagenr))
return 1;
return 0;
}
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-03-22 14:06    [W:0.037 / U:1.516 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site