Messages in this thread | | | Date | Tue, 14 Sep 2004 22:39:22 -0400 | From | Mark Lord <> | Subject | Re: [PATCH] New QStor SATA/RAID Driver for 2.6.9-rc2 |
| |
>Actually, its only wrong in queuecommand because that can be called in >softirq context. > >Sleeping in the eh paths is fine (as long as you drop the locks that the >EH thread has uselessly taken for you).
Good, that's how I understood it as well.
But the locking is certainly a mess as-is in the QStor driver. Sure, it is actually all technically correct, but hard to follow.
I believe I can remove nearly all of it and really tidy things up as a result.
Thanks guys, this has been really helpful so far. -- Mark Lord (hdparm keeper & the original "Linux IDE Guy") - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |