Messages in this thread | | | Date | Tue, 14 Sep 2004 14:35:02 -0400 | From | Jeff Garzik <> | Subject | Re: [PATCH] New QStor SATA/RAID Driver for 2.6.9-rc2 |
| |
On Tue, Sep 14, 2004 at 02:25:35PM -0400, James Bottomley wrote: > Sleeping in the eh paths is fine (as long as you drop the locks that the > EH thread has uselessly taken for you). Indeed it's often required > since the return is supposed to tell the eh thread whether the action > was successful or not.
I'm not sure this true for all arches?
The lock is taken in the SCSI layer with spin_lock_irqsave(), but the low-level driver cannot perform the exact opposite, spin_unlock_irqrestore(). The best they can do is spin_lock_irq(), which isnt 100% the same.
Jeff
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |