lkml.org 
[lkml]   [2004]   [Aug]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    Date
    SubjectRe: [PATCH] Fix netpoll cleanup on abort without dev
    ==> Regarding [PATCH] Fix netpoll cleanup on abort without dev; Matt Mackall <mpm@selenic.com> adds:

    mpm> If netpoll attempts to use a device without polling support, it will
    mpm> oops when shutting down. This adds a check that we've actually
    mpm> attached to a device.

    Hi, Matt,

    Perhaps I'm missing something, but how do we successfully return from
    netpoll_setup without np->dev filled in? Netpoll_setup has the following:

    if (!ndev->poll_controller) {
    printk(KERN_ERR "%s: %s doesn't support polling, aborting.\n",
    np->name, np->dev_name);
    goto release;
    }


    Thanks,

    Jeff
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2005-03-22 14:04    [W:0.042 / U:0.220 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site