lkml.org 
[lkml]   [2004]   [Aug]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] Fix netpoll cleanup on abort without dev
On Wed, Aug 04, 2004 at 10:54:01AM -0400, Jeff Moyer wrote:
> ==> Regarding [PATCH] Fix netpoll cleanup on abort without dev; Matt Mackall <mpm@selenic.com> adds:
>
> mpm> If netpoll attempts to use a device without polling support, it will
> mpm> oops when shutting down. This adds a check that we've actually
> mpm> attached to a device.
>
> Hi, Matt,
>
> Perhaps I'm missing something, but how do we successfully return from
> netpoll_setup without np->dev filled in? Netpoll_setup has the following:
>
> if (!ndev->poll_controller) {
> printk(KERN_ERR "%s: %s doesn't support polling, aborting.\n",
> np->name, np->dev_name);
> goto release;
> }

We don't. What happens is netconsole is blindly calling
netpoll_cleanup on module exit. I could move the np->dev check up to
that point, but it seems to me that netpoll_cleanup should be made
harmless instead.

ps: you still owe me a netpoll patch

--
Mathematics is the supreme nostalgia of our time.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-03-22 14:04    [from the cache]
©2003-2011 Jasper Spaans