[lkml]   [2004]   [Aug]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
    Patch in this message
    Subject[Patch] TIOCCONS security

    the ioctl TIOCCONS allows any user to redirect console output to another
    tty. This allows anyone to suppress messages to the console at will.

    AFAIK nowadays not many programs write to /dev/console, except for start
    scripts and the kernel (printk() above console log level).

    Still, I believe that administrators and operators would not like any
    user to be able to hijack messages that were written to the console.

    The only user of TIOCCONS that I am aware of is bootlogd/blogd, which
    runs as root. Please comment if there are other users.

    Is there any reason why normal users should be able to use TIOCCONS?

    Otherwise I would suggest to restrict access to root (CAP_SYS_ADMIN),
    e.g. with this patch.

    --- drivers/char/tty_io.c.orig 2004-08-25 12:51:17.000000000 +0200
    +++ drivers/char/tty_io.c 2004-08-25 17:05:15.097068780 +0200
    @@ -1566,10 +1566,10 @@

    static int tioccons(struct file *file)
    + if (!capable(CAP_SYS_ADMIN))
    + return -EPERM;
    if (file->f_op->write == redirected_tty_write) {
    struct file *f;
    - if (!capable(CAP_SYS_ADMIN))
    - return -EPERM;
    f = redirect;
    redirect = NULL;
    Olaf Dabrunz (od/odabrunz), SUSE Linux AG, Nürnberg

    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to
    More majordomo info at
    Please read the FAQ at

     \ /
      Last update: 2005-03-22 14:05    [W:0.020 / U:7.240 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site