[lkml]   [2004]   [Aug]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [1/4] Exceptions Notifier patch
Prasanna S Panchamukhi <> writes:

Just some cosmetical comments.

> +EXPORT_SYMBOL(register_die_chain_notify);

Please name it "register_die_notifier"

> static int kstack_depth_to_print = 24;
> +struct notifier_block *i386die_chain;
> +static DECLARE_MUTEX(i386die_chain_mutex);


I don't know why you made this a mutex, a spinlock would
be fine too. But that's a minor issue.

Rest looks ok.


To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to
More majordomo info at
Please read the FAQ at

 \ /
  Last update: 2005-03-22 14:05    [W:0.104 / U:0.968 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site