Messages in this thread | | | Date | Wed, 14 Jul 2004 07:33:04 -0400 | From | Ben Collins <> | Subject | Re: [PATCH] fix rmmod sbp2 hang in 2.6.7 |
| |
On Wed, Jul 14, 2004 at 10:24:17AM +0100, Russell King wrote: > On Wed, Jul 14, 2004 at 05:11:07PM +0800, Hugang wrote: > > On Wed, 14 Jul 2004 16:13:57 +0800 > > Hugang <hugang@soulinfo.com> wrote: > > | On Wed, 14 Jul 2004 11:48:54 +0800 > > | Hugang <hugang@soulinfo.com> wrote: > > | > > .... > > | Sorry, the above patch, can't fix rmmod sbp2 complete,I still got hang when > > | rmmod sbp2 in my PowerBook G4 sometimes. > > | > > > > This new patch can complete fix the bug. That's really hack. Any comment are > > welcome. > > This down+up prevents drivers from being unloaded until there are no > references to their struct device_driver. By removing this, you open > the very real possibility for an oops to occur. > > If you're waiting inside that function for the last reference to be > dropped, the real question is why you still have references to it.
Seems like every 2 months or so I have to revisit the sbp2 module to see where the scsi layer has changed (or the driver model) so that I can get all the reference counting to equal out properly. Guess it's been two months again :)
-- Debian - http://www.debian.org/ Linux 1394 - http://www.linux1394.org/ Subversion - http://subversion.tigris.org/ WatchGuard - http://www.watchguard.com/ - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |