lkml.org 
[lkml]   [2004]   [Jul]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] fix rmmod sbp2 hang in 2.6.7
On Wed, 14 Jul 2004 10:24:17 +0100
Russell King <rmk+lkml@arm.linux.org.uk> wrote:

| This down+up prevents drivers from being unloaded until there are no
| references to their struct device_driver. By removing this, you open
| the very real possibility for an oops to occur.
Yes, I agree with you. When sbp2 is using the module count is not zero,
so I can rmmod it, So I think, for sbp2 that's safe, That's true on my laptop.

|
| If you're waiting inside that function for the last reference to be
| dropped, the real question is why you still have references to it.
There are tree places that reference ->unload_sem in linux kernel tree, but I
don't known, why the same code in 2.6.4 can works fine. :)

bus.c:68: up(&drv->unload_sem);
driver.c:110: down(&drv->unload_sem);
driver.c:111: up(&drv->unload_sem);

--
Hu Gang / Steve
Linux Registered User 204016
GPG Public Key: http://soulinfo.com/~hugang/hugang.asc
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-03-22 14:04    [W:0.045 / U:3.252 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site