Messages in this thread | | | Date | Wed, 30 Jun 2004 21:27:09 +1000 | From | Paul Mackerras <> | Subject | Re: [PATCH] PPC64: lockfix for rtas error log |
| |
Linas,
> This patch moves the location of a lock in order to protect > the contents of a buffer until it has been copied to its final > destination. Prior to this, a race existed whereby the buffer > could be filled even while it was being emptied.
Given that log_error() seems to be a no-op at the moment AFAICT, and that Ben H was concerned about possible deadlocks if log_error actually did do something, I'd like to see a resolution of (a) what log_error should be doing and (b) whether there is in fact any possibility of deadlock with this patch once (a) is resolved.
Thanks, Paul. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |