lkml.org 
[lkml]   [2004]   [May]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH] AES i586 optimized, regparm fixed
From
On Fri, May 14, 2004 at 02:19:23PM +0100, Christoph Hellwig wrote:

> We usually use asmlinkage instead of __attribute__((regparm(0))). while
> it's not nessecary for x86-specific code to abstract this out it at least
> looks cleaner.

I will change that.

> BTW, is the assembly code shared with some other project?
> If not it might be a good idea to kill the ifdefs in there.

The only project I'm aware of is loop-aes. aes-i586-asm.S is different wrt
to the parameter positions anyway (cryptoapi source/dest switched). The code
is not subject to regular modifications so, we might kill the #if directives
if we like.

Regards, Clemens
[unhandled content-type:application/pgp-signature]
\
 
 \ /
  Last update: 2005-03-22 14:03    [W:0.029 / U:0.212 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site