Messages in this thread | | | Date | Fri, 14 May 2004 15:26:15 +0200 | From | bert hubert <> | Subject | Re: [PATCH] AES i586 optimized, regparm fixed |
| |
On Fri, May 14, 2004 at 03:07:24PM +0200, Fruhwirth Clemens wrote:
> +config CRYPTO_AES_586 > + tristate "AES cipher algorithms (586)" > + depends on CRYPTO && X86 && !X86_64 > + help > + AES cipher algorithms (FIPS-197). AES uses the Rijndael > + algorithm.
I'm wondering if this should be a configurable setting. Reminds me of older programs asking if they should do something using the 'fast' or 'slow' algorithm, even though results were identical.
If we trust the AES assembler code, and it is supposed to be faster on >586, it should be the default on those CPUs as there is no gain in using the C version.
On the other hand, if we think there are situations when the new assembler code won't be correct or faster, we should not merge it.
In any case, Kconfig does not seem the way to go.
-- http://www.PowerDNS.com Open source, database driven DNS Software http://lartc.org Linux Advanced Routing & Traffic Control HOWTO - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |