Messages in this thread | | | Date | Thu, 8 Apr 2004 22:28:10 +0200 (MEST) | From | Geert Uytterhoeven <> | Subject | Re: [PATCH] obsolete asm/hdreg.h [3/5] |
| |
On Thu, 8 Apr 2004, Bartlomiej Zolnierkiewicz wrote: > On Thursday 08 of April 2004 10:49, Geert Uytterhoeven wrote: > > On Thu, 8 Apr 2004, Bartlomiej Zolnierkiewicz wrote: > > > [IDE] asm/ide.h: ide_ioreg_t cleanup > > > > > > ide_ioreg_t is deprecated and hasn't been used by IDE driver for some > > > time. Use unsigned long directly on alpha, arm26, arm, mips, parisc, > > > ppc64 and sh. > > > > > > asm-ia64/ide.h (ide_ioreg_t is unsigned short) and asm-m68knommu/ide.h > > > (broken - ide_ioreg_t is not defined) are the only users of ide_ioreg_t > > > left. > > > > Why do you consider asm-m68knommu/ide.h broken? > > > > It just includes <asm-m68k/hdreg.h>, which is definitely not broken since > > it's happily (albeit very slowly) running apt-get upgrade right now ;-) > > Well... > > In kernel 2.5.70 ide_ioreg_t typedef was removed from > <asm-m68k/hdreg.h> and it is used all over <asm-m68knommu/ide.h>.
Ah, now I see. I didn't really notice you were also talking about ide.h, not hdreg.h ;-)
> I see that this is fixed in linux-m68k-cvs but... > > <asm-m68knommu/ide.h> hasn't been updated since kernel 2.5.46 > and still depends on inlines which were removed from IDE code: > - ide_request_irq() (special case for COLDFIRE) > - ide_{request, release}_region(), > which are empty because M68K use memory IO > - ide_fix_driveid() (special case for COLDFIRE), > conflicts with generic version in drivers/ide/ide-iops.c > - maybe more > > This issues are not fixed in linux-m68k-cvs tree. > [ Is there a separate m68knommu tree? ]
The uClinux tree? But I don't think these issues were solved there yet, since the latest uc patch is quite small.
Gr{oetje,eeting}s,
Geert
-- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |