lkml.org 
[lkml]   [2004]   [Apr]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    SubjectRe: [PATCH] obsolete asm/hdreg.h [3/5]
    Date
    On Thursday 08 of April 2004 10:49, Geert Uytterhoeven wrote:
    > On Thu, 8 Apr 2004, Bartlomiej Zolnierkiewicz wrote:
    > > [IDE] asm/ide.h: ide_ioreg_t cleanup
    > >
    > > ide_ioreg_t is deprecated and hasn't been used by IDE driver for some
    > > time. Use unsigned long directly on alpha, arm26, arm, mips, parisc,
    > > ppc64 and sh.
    > >
    > > asm-ia64/ide.h (ide_ioreg_t is unsigned short) and asm-m68knommu/ide.h
    > > (broken - ide_ioreg_t is not defined) are the only users of ide_ioreg_t
    > > left.
    >
    > Why do you consider asm-m68knommu/ide.h broken?
    >
    > It just includes <asm-m68k/hdreg.h>, which is definitely not broken since
    > it's happily (albeit very slowly) running apt-get upgrade right now ;-)

    Well...

    In kernel 2.5.70 ide_ioreg_t typedef was removed from
    <asm-m68k/hdreg.h> and it is used all over <asm-m68knommu/ide.h>.

    I see that this is fixed in linux-m68k-cvs but...

    <asm-m68knommu/ide.h> hasn't been updated since kernel 2.5.46
    and still depends on inlines which were removed from IDE code:
    - ide_request_irq() (special case for COLDFIRE)
    - ide_{request, release}_region(),
    which are empty because M68K use memory IO
    - ide_fix_driveid() (special case for COLDFIRE),
    conflicts with generic version in drivers/ide/ide-iops.c
    - maybe more

    This issues are not fixed in linux-m68k-cvs tree.
    [ Is there a separate m68knommu tree? ]

    I hope you now don't regret asking this question... ;-)

    Cheers,
    Bartlomiej

    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2005-03-22 14:02    [W:0.027 / U:31.520 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site