Messages in this thread Patch in this message | | | Date | Wed, 3 Mar 2004 20:06:25 -0800 | From | Chris Wright <> | Subject | [PATCH] class_simple cleanup in sg |
| |
The only spot that seems to care about class_simple_device_add possibly failing, but it gets the wrong error test.
===== drivers/scsi/sg.c 1.81 vs edited ===== --- 1.81/drivers/scsi/sg.c Fri Feb 6 00:21:23 2004 +++ edited/drivers/scsi/sg.c Wed Mar 3 19:56:13 2004 @@ -1439,7 +1439,7 @@ MKDEV(SCSI_GENERIC_MAJOR, k), cl_dev->dev, "%s", disk->disk_name); - if (NULL == sg_class_member) + if (IS_ERR(sg_class_member)) printk(KERN_WARNING "sg_add: " "class_simple_device_add failed\n"); class_set_devdata(sg_class_member, sdp); - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |