Messages in this thread | | | Subject | Re: [PATCH] ppc32: macserial.c missing variable declaration | From | Benjamin Herrenschmidt <> | Date | Wed, 03 Mar 2004 09:53:04 +1100 |
| |
> This can't be right. Those variables are never initialized anywhere. > > The usage of 'cmd' should either be removed entirely, or it should be > passed in as an argument, it looks like. In the meantime, it's better to > have code that doesn't compile than code that compiles but can't possibly > do anything sane.
macserial is obsolete on 2.6. it should be removed. pmac_zilog is the replacement.
I still haven't found the bug with pmac_zilog that caused the occasional crash on boot on the G5 though (it seems to be a subtle race, I haven't found anything wrong with pmac_zilog itself), but then, I've been quite busy with other things latey.
Ben.
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |