lkml.org 
[lkml]   [2004]   [Mar]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
Subject[PATCH] ppc32: Fix crash on load in DACA sound driver
From
Date
Hi !

The DACA sound driver (early iBook models) doesn't clear the i2c_client
structure. That cause the embedded struct device (and thus kobject) to
contain garbage in the "k_name" field, which kobject_set_name will
later try to kfree...
Also removes references to unused struct data_data.

===== sound/oss/dmasound/dac3550a.c 1.2 vs edited =====
--- 1.2/sound/oss/dmasound/dac3550a.c Tue Sep 30 10:25:28 2003
+++ edited/sound/oss/dmasound/dac3550a.c Tue Mar 2 21:32:04 2004
@@ -42,11 +42,6 @@
/* Unique ID allocation */
static int daca_id;

-struct daca_data
-{
- int arf; /* place holder for furture use */
-};
-
struct i2c_driver daca_driver = {
.owner = THIS_MODULE,
.name = "DAC3550A driver V " DACA_VERSION,
@@ -168,12 +163,12 @@
{
const char *client_name = "DAC 3550A Digital Equalizer";
struct i2c_client *new_client;
- struct daca_data *data;
int rc = -ENODEV;

- new_client = kmalloc(sizeof(*new_client) + sizeof(*data), GFP_KERNEL);
+ new_client = kmalloc(sizeof(*new_client), GFP_KERNEL);
if (!new_client)
return -ENOMEM;
+ memset(new_client, 0, sizeof(*new_client));

new_client->addr = address;
new_client->adapter = adapter;
@@ -181,9 +176,6 @@
new_client->flags = 0;
strcpy(new_client->name, client_name);
new_client->id = daca_id++; /* racy... */
-
- data = (struct daca_data *)(new_client+1);
- dev_set_drvdata(&new_client->dev, data);

if (daca_init_client(new_client))
goto bail;

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-03-22 14:01    [W:0.066 / U:0.024 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site