Messages in this thread Patch in this message | | | Date | Tue, 19 Oct 2004 18:07:33 -0700 | Subject | [PATCH 2.6 IrDA] Stir driver usb reset fix | From | Jean Tourrilhes <> |
| |
irXXX_stir_reset.diff : ~~~~~~~~~~~~~~~~~~~~~ <Patch from Stephen Hemminger> o [CORRECT] stir4200 - get rid of reset on speed change The Sigmatel 4200 doesn't accept the address setting which gets done on USB reset. The USB core recently changed to resend address (or something like that), so usb_reset_device is failing.
The device works without doing the USB reset on speed change, it just will be less robust in recovering when things get wedged (like coming out of FIR mode).
Signed-off-by: Stephen Hemminger <shemminger@osdl.org> Signed-off-by: Jean Tourrilhes <jt@hpl.hp.com>
diff -Nru a/drivers/net/irda/stir4200.c b/drivers/net/irda/stir4200.c --- a/drivers/net/irda/stir4200.c 2004-10-08 14:01:29 -07:00 +++ b/drivers/net/irda/stir4200.c 2004-10-08 14:01:29 -07:00 @@ -520,11 +520,6 @@ found: pr_debug("speed change from %d to %d\n", stir->speed, speed); - /* sometimes needed to get chip out of stuck state */ - err = usb_reset_device(stir->usbdev); - if (err) - goto out; - /* Reset modulator */ err = write_reg(stir, REG_CTRL1, CTRL1_SRESET); if (err)
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |