lkml.org 
[lkml]   [2003]   [Sep]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: div64.h:do_div() bug
On Tue, 30 Sep 2003, Andreas Schwab wrote:
> Matti Aarnio <matti.aarnio@zmailer.org> writes:
> > On Tue, Sep 30, 2003 at 01:14:38PM +0300, Matti Aarnio wrote:
> >> On Tue, Sep 30, 2003 at 11:52:29AM +0200, Rogier Wolff wrote:
> >> > On Mon, Sep 29, 2003 at 03:25:19PM +0200, Artur Klauser wrote:
> >> > > I've found that a bug in asm-arm/div64.h:do_div() is preventing correct
> >> > > conversion of timestamps in smbfs (and probably ntfs as well) from NT to
> >> >
> >> > Nope.
> >>
> >> Nope yourself.
> >>
> >> > > if (in.n64 != out.n64) {
> >> > > printf("FAILURE: asm/div64.h:do_div() is broken for 64-bit dividends\n");
> >> >
> >> > do_div should be/is documented as not doing 64 bit dividents. It does
> >> > 64/32 -> 32 divides, IIRC...
> >>
> >> 64/32 -> 64,32
> >>
> >> The REMAINDER is 32 bit value.
> >
> > Non-native english speaker makes the mistake.. MODULUS is 32 bits as is
> > DIVISOR, REMAINDER is 64 bit, as is DIVIDEND.
> >
> > That is:
> > DIVIDEND / DIVISOR -> REMAINDER , MODULUS
> ^^^^^^^^^^^^^^^^^^^
> ???
> QUOTIENT, REMAINDER

Actually, I have to agree with Andreas here - and with Matti's 1st naming
attempt :)

But whatever the naming is, the operation AFAICT should be, and is
implemented that way in other asm-<arch>/div64.h:do_div() macros:

do_div(u64, u32)
u64 / u32 -> u64 (modifies 1st argument)
u64 % u32 -> u32 (return value)

-r2r-
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-03-22 13:49    [W:0.051 / U:0.336 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site