lkml.org 
[lkml]   [2003]   [Sep]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: s390 patches: descriptions.
From
Date

> What's wrong with current zcrypt from 2.4, aside from the
> reading from urandom? It looked a relatively decent driver to me.

Reading from urandom, the ioctls are sick (linked lists in user that
are parsed by the kernel) and the timer stuff is somewhat strange
as well. Some of it has its reason in the hardware interface.
What really bothers me is
1) coding style
2) coding style
and
3) coding style.

blue skies,
Martin


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-03-22 13:48    [W:0.119 / U:0.256 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site