lkml.org 
[lkml]   [2003]   [Sep]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH SET][bonding] cleanup
Date
On Thursday 25 September 2003 07:22 pm, Jay Vosburgh wrote:
> >patch 7 - eliminate the multicast_mode module param. settings are
> > now done only according to mode.
>
> This goes a bit beyond straight cleanup; could you explain
> the rationale for this change? Also, unless I'm missing something,
> the patch does not appear to update bonding.txt to reflect the fact
> that the module parameter is no more.
>
>

That question rings a bell :)
I had this discussion with Deniel Laurent on 8/30 and it sounded like
that wouldn't be a problem after all.

[from that thread]
> Do you know that this breaks upward compatibility ?
[snip]
> But if everyone is OK ... (I'd be since I currently only use
> multicast_mode = 1 ;-).

The rationale is that the propagation code already made this module
param obsolete, so the next step was to remove it entirely since it
had no effect anyway.

According to the propagation RFC we sent on 2/6, multicast list,
allmulti flag and promisc flag are all controlled the same way, and
that is according to the USES_PRIMARY macro. When the bond uses the
current slave as a primary interface, it, and only it, is supposed to
have the bond's properties, while in aggregation modes all slaves
have the same settings. There is no point in settings other slaves,
that are not supposed to be receiving in the first place, to have
loose filtering. Otherwise the stack will be flooded by duplicate
packets. The situation is bad enough now since bonding has no
solution for broadcast packets, but that's for another thread.

--
| Shmulik Hen Advanced Network Services |
| Israel Design Center, Jerusalem |
| LAN Access Division, Platform Networking |
| Intel Communications Group, Intel corp. |

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-03-22 13:48    [W:0.031 / U:0.688 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site