Messages in this thread | | | Date | Sat, 9 Aug 2003 05:01:50 +0200 (CEST) | From | Andreas Gruenbacher <> | Subject | Re: [PATCH] 2.4: Restore current->files in flush_old_exec |
| |
On Sat, 9 Aug 2003, Herbert Xu wrote:
> On Sat, Aug 09, 2003 at 04:20:38AM +0200, Andreas Gruenbacher wrote: > > On Sat, 9 Aug 2003, Herbert Xu wrote: > > > > > On Sat, Aug 09, 2003 at 11:11:16AM +1000, herbert wrote: > > > > > > > > At this point, I believe the unshare_files stuff should be fine from > > > > a correctness point of view. However, there is still a performance > > > > problem as every ELF exec call ends up dupliating the files structure > > > > as well as walking through all file locks. > > > > > > Here is the patch that ensures files is only duplicated when necessary. > > > > This patch is correct but unnecessary: steal_locks already tests for this > > condition. > > Yes but when you call unshare_files twice one of them will have to > copy.
I see---that happens through flush_old_exec. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |