Messages in this thread | | | Date | Sat, 9 Aug 2003 12:53:11 +1000 | Subject | Re: [PATCH] 2.4: Restore current->files in flush_old_exec | From | Herbert Xu <> |
| |
On Sat, Aug 09, 2003 at 04:20:38AM +0200, Andreas Gruenbacher wrote: > On Sat, 9 Aug 2003, Herbert Xu wrote: > > > On Sat, Aug 09, 2003 at 11:11:16AM +1000, herbert wrote: > > > > > > At this point, I believe the unshare_files stuff should be fine from > > > a correctness point of view. However, there is still a performance > > > problem as every ELF exec call ends up dupliating the files structure > > > as well as walking through all file locks. > > > > Here is the patch that ensures files is only duplicated when necessary. > > This patch is correct but unnecessary: steal_locks already tests for this > condition.
Yes but when you call unshare_files twice one of them will have to copy. -- Debian GNU/Linux 3.0 is out! ( http://www.debian.org/ ) Email: Herbert Xu ~{PmV>HI~} <herbert@gondor.apana.org.au> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |