lkml.org 
[lkml]   [2003]   [Aug]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: Add identify decoding 4/4
> I know full well _why_ the big function is in the header;
> that doesn't address my point: we don't need to be putting
> big functions in header files. That's why libraries were invented

Well. I chose the most elegant solution I saw.

If you see a better solution, I would like to see it.
Note that local symbols in several files determine
whether this function should be compiled or not.

Also, consider the following.
This file *is* a library. It contains a hundred
(in the version you saw half a dozen) one-line
static inline functions. That is the real library.
It describes all identify stuff.
And there is a single large function used for debugging,
invisible unless a debugging symbol is defined.

I cannot see anything wrong with that.
You are very narrow minded if you are blinded by the
fact that the name ends in an h.

Andries
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-03-22 13:47    [W:0.048 / U:0.792 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site