Messages in this thread Patch in this message | | | From | Francesco Sportolari <> | Subject | [bug 1080] [PATCH] 2.6.0-t3: alsa driver snd-powermac doesn't work with tumbler chip on ibook2 | Date | Sun, 17 Aug 2003 23:54:06 +0200 |
| |
During the insmod of the snd-powermac module this msg is printed to the console:
tumbler: cannot initialize the MCS
After that, even if the module is loaded correctly, the sound doesn't work at all.
I've noticed that removing and inserting again the 'i2c-keywest' module solves the problem. The following patch fixes this issue related to early initialization of the i2c client in the driver.
Bye, -- Francesco
--- orig/sound/ppc/tumbler.c 2003-08-16 17:18:35.000000000 +0200 +++ linux-2.6.0-test3/sound/ppc/tumbler.c 2003-08-16 17:18:55.000000000 +0200 @@ -996,9 +996,6 @@ chipname = "Snapper"; }
- if ((err = snd_pmac_keywest_init(&mix->i2c)) < 0) - return err; - /* * build mixers */ @@ -1025,6 +1022,9 @@ if ((err = tumbler_init(chip)) < 0) return err;
+ if ((err = snd_pmac_keywest_init(&mix->i2c)) < 0) + return err; + #ifdef CONFIG_PMAC_PBOOK chip->resume = tumbler_resume; #endif
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |