lkml.org 
[lkml]   [2003]   [Aug]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
From
Subject[bug 1080] [PATCH] 2.6.0-t3: alsa driver snd-powermac doesn't work with tumbler chip on ibook2
Date
During the insmod of the snd-powermac module this msg is printed to the 
console:

tumbler: cannot initialize the MCS

After that, even if the module is loaded correctly, the sound doesn't work at
all.

I've noticed that removing and inserting again the 'i2c-keywest' module solves
the problem. The following patch fixes this issue related to early
initialization of the i2c client in the driver.

Bye,
-- Francesco

--- orig/sound/ppc/tumbler.c 2003-08-16 17:18:35.000000000 +0200
+++ linux-2.6.0-test3/sound/ppc/tumbler.c 2003-08-16 17:18:55.000000000
+0200
@@ -996,9 +996,6 @@
chipname = "Snapper";
}

- if ((err = snd_pmac_keywest_init(&mix->i2c)) < 0)
- return err;
-
/*
* build mixers
*/
@@ -1025,6 +1022,9 @@
if ((err = tumbler_init(chip)) < 0)
return err;

+ if ((err = snd_pmac_keywest_init(&mix->i2c)) < 0)
+ return err;
+
#ifdef CONFIG_PMAC_PBOOK
chip->resume = tumbler_resume;
#endif

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-03-22 13:47    [W:0.026 / U:4.936 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site