Messages in this thread | | | Subject | RE: [Dri-devel] Re: [PATCH] CodingStyle fixes for drm_agpsupport | Date | Mon, 11 Aug 2003 13:21:22 -0700 | From | "Sottek, Matthew J" <> |
| |
> if (!pointer) { > return (whatever); > } > > >because it's consistent, and guaranteed safe from stupid >parsing errors that can waste days of debug time when >someone decides to add to it. >("its just a little change that cant hurt anything", ha ha)
I've always been an "Always use brackets" evangelist for two reasons. 1) The time it takes to write the code fragment is noise compared to the amount of cumulative time that everyone else will spend reading it over it's lifespan. This is more true in open source than it ever was in the closed source world. Making the code explicit saves everyone time in the longrun.
2) There are some very real ways that bracketless code will get broken. Either someone adds a line that didn't notice the lack of brackets or, someone accidentally uses a multi-line macro.
i.e. if(foo) DEBUG_PRINT("Foo!\n");
works great for 100 years until someone recodes the DEBUG_PRINT macro to be 2 lines. The Linux kernel often has plain looking functions or variables that end up being macros (and may only expand to multi-line on some platforms) which could easily get you into such a situation.
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |