lkml.org 
[lkml]   [2003]   [Aug]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] CodingStyle fixes for drm_agpsupport
A few comments on why I don't like this patch:
1) It's a formatting only patch. That screws over people who are using
BK for debugging, now when I double click on these changes I'll get
to your cleanup patch, not the patch that was the last substantive
change.
2) "if (expr) statement;" really ought to be considered legit coding style.
It's a one line "shorty" and it lets you see more of the code on a
screen.

On the other hand, the author carried things too far when they did

if (expr) statement;
else statement;

that's too hard for your eyes to parse quickly IMO.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-03-22 13:47    [W:0.063 / U:0.516 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site