[lkml]   [2003]   [Aug]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [PATCH] CodingStyle fixes for drm_agpsupport
Larry McVoy wrote:
> That ought to be balanced with "don't screw up the revision history, people
> use it". It's one thing to reformat code that is unreadable, for the most
> part this code didn't come close to unreadable.


> I wasn't suggesting that. I was saying
> if (expr) statement; // OK

The test and the statement run together visually, which is it is
preferred to put the statement on the following line.

> The exception I was saying was reasonable is if you are doing something like
> if (!pointer) return (-EINVAL);
> Short, sweet, readable, no worries.

return is not a function ;-)


To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to
More majordomo info at
Please read the FAQ at

 \ /
  Last update: 2005-03-22 13:47    [from the cache]
©2003-2014 Jasper Spaans. hosted at Digital Ocean