Messages in this thread Patch in this message | | | Date | Fri, 18 Jul 2003 15:29:12 +0100 | From | Alan Cox <> | Subject | PATCH: btaudio uses memset so should be strlcpy |
| |
(I've got a patch pending from someone to redo the lot using memset so its safe from padding suprises)
diff -u --new-file --recursive --exclude-from /usr/src/exclude linux-2.6.0-test1/sound/oss/btaudio.c linux-2.6.0-test1-ac2/sound/oss/btaudio.c --- linux-2.6.0-test1/sound/oss/btaudio.c 2003-07-14 14:11:57.000000000 +0100 +++ linux-2.6.0-test1-ac2/sound/oss/btaudio.c 2003-07-14 14:27:14.000000000 +0100 @@ -328,8 +328,8 @@ if (cmd == SOUND_MIXER_INFO) { mixer_info info; memset(&info,0,sizeof(info)); - strncpy(info.id,"bt878",sizeof(info.id)); - strncpy(info.name,"Brooktree Bt878 audio",sizeof(info.name)); + strlcpy(info.id,"bt878",sizeof(info.id)); + strlcpy(info.name,"Brooktree Bt878 audio",sizeof(info.name)); info.modify_counter = bta->mixcount; if (copy_to_user((void *)arg, &info, sizeof(info))) return -EFAULT; @@ -338,8 +338,8 @@ if (cmd == SOUND_OLD_MIXER_INFO) { _old_mixer_info info; memset(&info,0,sizeof(info)); - strncpy(info.id,"bt878",sizeof(info.id)-1); - strncpy(info.name,"Brooktree Bt878 audio",sizeof(info.name)); + strlcpy(info.id,"bt878",sizeof(info.id)-1); + strlcpy(info.name,"Brooktree Bt878 audio",sizeof(info.name)); if (copy_to_user((void *)arg, &info, sizeof(info))) return -EFAULT; return 0; - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |