Messages in this thread Patch in this message | | | Date | Mon, 30 Jun 2003 14:52:33 +0100 | From | Richard Curnow <> | Subject | NFS structure allocation alignment patch |
| |
Hi Trond, Marcelo,
Below is a patch against 2.4.21 to tidy up the allocation of two structures in nfs3_proc_unlink_setup. We need this change for NFS to work on the sh64 architecture, which has just been merged into 2.4 in the last couple of days. Otherwise, 'res' is 4-byte aligned but not necessarily 8-byte aligned, but struct nfs_attr contains fields that are 8 bytes wide. This leads to alignment exceptions on loads and stores into that structure.
Can you consider this for inclusion before 2.4.22 please?
[BTW this is the same fix we discussed about 3 months ago; I didn't get around to re-submitting the fix at the time].
Regards, Richard Curnow
--- fs/nfs/nfs3proc.c Thu Nov 28 23:53:15 2002 +++ ../sh5linux-16062003/fs/nfs/nfs3proc.c Mon Jun 30 11:43:14 2003 @@ -300,11 +300,16 @@ { struct nfs3_diropargs *arg; struct nfs_fattr *res; + struct unlinkxdr { + struct nfs3_diropargs arg; + struct nfs_fattr res; + } *ptr; - arg = (struct nfs3_diropargs *)kmalloc(sizeof(*arg)+sizeof(*res), GFP_KERNEL); - if (!arg) + ptr = (struct unlinkxdr *) kmalloc(sizeof(struct unlinkxdr), GFP_KERNEL); + if (!ptr) return -ENOMEM; - res = (struct nfs_fattr*)(arg + 1); + arg = &ptr->arg; + res = &ptr->res; arg->fh = NFS_FH(dir->d_inode); arg->name = name->name; arg->len = name->len; -- Richard \\\ SuperH Core+Debug Architect /// .. At home .. P. /// richard.curnow@superh.com /// rc@rc0.org.uk Curnow \\\ http://www.superh.com/ /// www.rc0.org.uk - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |