Messages in this thread Patch in this message | | | Date | Thu, 27 Mar 2003 18:16:46 GMT | From | Alan Cox <> | Subject | PATCH: DRIVERNAME SUPPRESSED DUE TO KERNEL.ORG FILTER BUGS |
| |
Add a comment that the irq_nosync stuff needs revisiting diff -u --new-file --recursive --exclude-from /usr/src/exclude linux-2.5.66-bk3/drivers/ide/ide-iops.c linux-2.5.66-ac1/drivers/ide/ide-iops.c --- linux-2.5.66-bk3/drivers/ide/ide-iops.c 2003-03-27 17:13:18.000000000 +0000 +++ linux-2.5.66-ac1/drivers/ide/ide-iops.c 2003-03-26 20:05:24.000000000 +0000 @@ -903,6 +903,14 @@ * Select the drive, and issue the SETFEATURES command */ disable_irq_nosync(hwif->irq); + + /* + * FIXME: we race against the running IRQ here if + * this is called from non IRQ context. If we use + * disable_irq() we hang on the error path. Work + * is needed. + */ + udelay(1); SELECT_DRIVE(drive); SELECT_MASK(drive, 0); - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |