Messages in this thread | | | Date | Tue, 18 Mar 2003 17:27:02 +1200 | From | Nigel Cunningham <> | Subject | Re: [PATCH] Don't refill pcp lists during SWSUSP. |
| |
On Tue, 2003-03-18 at 12:05, Andrew Morton wrote: > Nigel Cunningham <ncunningham@clear.net.nz> wrote: > > > > +extern unsigned int suspend_task; > > > Please do: > > #ifdef CONFIG_SOFTWARE_SUSPEND > unsigned int suspend_task; > #else > #define suspend_task 0 > #endif > > so the compiler can remove the few fast-path instructions which you have > added.
Okee doke. Will do.
I said I was going to use dynamically allocated bitmaps instead of page flags. Do you mind if I do use pageflags after all (at least for the moment)? I've used one in the generate_free_page_map patch, and need one more to mark pages which will be saved in another pageset.
> > > > + suspend_task = current->pid; > > + > > Zero is a valid PID (the idle task...). It might be clearer to make > suspend_task a task_struct*.
Mmm, but I will use suspend_task elsewhere and wanted to make the test simple (zero = not suspending at the moment; since init will never be the suspend task, it's safe usage).
Regards,
Nigel
-- Nigel Cunningham 495 St Georges Road South, Hastings 4201, New Zealand
Be diligent to present yourself approved to God as a workman who does not need to be ashamed, handling accurately the word of truth. -- 2 Timothy 2:14, NASB.
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |