[lkml]   [2003]   [Mar]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [PATCH] Don't refill pcp lists during SWSUSP.
Hi Pavel.

You need to remember that this is infrastructure for later. I tried it
other ways and would have needed a number of calls to drain local pages.
Perhaps I'm taking the wrong approach, trying to feed a patch at a time
when you can't see how it all fits together. If you like, I'll send a
'whole kit and caboodle' patch as soon as I get the last bugs ironed
out. I have it suspending and resuming at the moment, but have one last
bug to iron out that's stopping me getting back from
do_suspend_lowlevel. It's just a matter of time, and then that will be
fixed. I could send you a monster patch then :> (I'll be posting it
somewhere anyway - I'll want others to test it, of course).



On Tue, 2003-03-18 at 20:18, Pavel Machek wrote:
> Hi!
> > Here's another patch (the last for a little while, I promise!). It stops
> > the pcp lists from being refilled while SWSUSP is running. Despite the
> > comment in the page, drain_local_pages does only need to get called once
> > right now, but I have patches coming that will (DV) change that. This
> > patch is thus groundwork for them.
> This adds external (and pretty ugly) dependency of swsusp on the
> outside. And as it still needs to drain_local_pages(), nothing is
> gained. I believe it is better to just call drain_local_pages few
> times. Magic hooks "if suspending, don't do this" seem like wrong
> approach to me.
> Pavel
Nigel Cunningham
495 St Georges Road South, Hastings 4201, New Zealand

Be diligent to present yourself approved to God as a workman who does
not need to be ashamed, handling accurately the word of truth.
-- 2 Timothy 2:14, NASB.

To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to
More majordomo info at
Please read the FAQ at

 \ /
  Last update: 2005-03-22 13:34    [W:0.098 / U:0.248 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site