lkml.org 
[lkml]   [2003]   [Feb]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRE: [BUG] 2.5.63: ESR killed my box!
Date
> From: Linus Torvalds [mailto:torvalds@transmeta.com] 
> Wouldn't it be nicer to just fix the write instead? I can see the
> potential to actually want to change the APIC ID - in
> particular, if the
> SMP MP tables say that the APIC ID for the BP should be X,
> maybe we should
> actually write X to it instead of just using what is there.

OK so we have a redundancy. You can get the same info from MPS and from
the lapic itself.

The fact that ACPI's boot tables does not include the lapic id (just its
address) suggests strongly to me that we should similarly query the
lapic for its address instead of writing in a new value when using the
MPS tables, as well.

> In particular, Mikaels patch will BUG() if the MP tables
> don't match the
> APIC ID. I think that's extremely rude: we should select one
> of the two
> and just run with it, instead of unconditionally failing.

Agree.

Regards -- Andy
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-03-22 13:33    [W:0.025 / U:5.932 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site